lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c6f7a11-b406-d4f1-c934-e6dedf5b07fd@redhat.com>
Date:   Mon, 7 Jan 2019 17:39:33 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     lantianyu1986@...il.com
Cc:     kvm@...r.kernel.org, catalin.marinas@....com, will.deacon@....com,
        paulus@...abs.org, hpa@...or.com, kys@...rosoft.com,
        kvmarm@...ts.cs.columbia.edu, mpe@...erman.id.au, x86@...nel.org,
        linux@...linux.org.uk, michael.h.kelley@...rosoft.com,
        mingo@...hat.com, benh@...nel.crashing.org, jhogan@...nel.org,
        linux-mips@...r.kernel.org, Lan Tianyu <Tianyu.Lan@...rosoft.com>,
        marc.zyngier@....com, kvm-ppc@...r.kernel.org, bp@...en8.de,
        tglx@...utronix.de, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, ralf@...ux-mips.org,
        paul.burton@...s.com, vkuznets@...hat.com,
        linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH 4/11] KVM/MMU: Introduce tlb flush with range list

On 04/01/19 09:53, lantianyu1986@...il.com wrote:
>  struct kvm_mmu_page {
>  	struct list_head link;
> +
> +	/*
> +	 * Tlb flush with range list uses struct kvm_mmu_page as list entry
> +	 * and all list operations should be under protection of mmu_lock.
> +	 */
> +	struct list_head flush_link;
>  	struct hlist_node hash_link;
>  	bool unsync;
>  
> @@ -443,6 +449,7 @@ struct kvm_mmu {

Again, it would be nice not to grow the struct too much, though I
understand that it's already relatively big (168 bytes).

Can you at least make this an hlist, so that it only takes a single word?

Paolo

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ