linux-kernel - Re: [PATCH] Input: goodix - decouple irq and reset lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190107164225.GA5394@agonzal-linux>
Date:   Mon, 7 Jan 2019 16:42:26 +0000
From:   "Gonzalez, Alex" <Alex.Gonzalez@...i.com>
To:     Bastien Nocera <hadess@...ess.net>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: goodix - decouple irq and reset lines

Hi Bastien,

>Given that we do have access to the datasheet, it would also be useful
>for the patch to mention where in the datasheet it says that the reset
>line can be left pulled-up,

The pin description table on section 4, on the "Reset pin" row, contains a 
remark as follows:

External 10K pull-up resistor required, active-low reset

This comes from a newer revision of the datasheet though:
http://focuslcds.com/content/GT911.pdf

I guess it's open to interpretation whether driving the reset line is 
optional. The code seemed to imply it by using devm_gpiod_get_optional() to 
obtain the GPIO.

>or mention on which shipping device this
>setup is already used (and if so, what the DTS or ACPI snippet that
>declares those is).
>

I am testing with an LCD application kit for the ConnectCore 6UL SBC Pro:

https://www.digi.com/products/models/cc-acc-lcdw-10
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/imx6ul-ccimx6ulsbcpro.dts?h=v5.0-rc1#n120

This display in particular does not have the reset line available on the 
connector. The only way to make it work seems to be to use the INT line to fix 
an I2C address.

>Cheers
>