linux-kernel - Re: [PATCH] video: offb: Pass actual name in offb_init_palette

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqL=Q4cct+ZQR4VOnxxDsUog5D54hUqjjTYhtHV4d1LB-Q@mail.gmail.com>
Date:   Mon, 7 Jan 2019 11:31:12 -0600
From:   Rob Herring <robh@...nel.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        "# v4 . 11" <stable@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Elimar Riesebieter <riesebie@...ec.de>
Subject: Re: [PATCH] video: offb: Pass actual name in offb_init_palette_hacks

On Wed, Jan 2, 2019 at 2:03 PM Mathieu Malaterre <malat@...ian.org> wrote:
>
> Bartlomiej,
>
> Do you need an Acked-by from Rob, or can you take it in the next round
> of fixes for v4.20 ?

Sorry, I missed this.

>
> Just to repeat myself, previous code would call
> offb_init_palette_hacks(), which in turn would do:
>
>        if (dp && !strncmp(name, "ATY,Rage128", 11)) {
>
> with name=NULL.

I prefer to fix this properly using node name helper in
offb_init_palette_hacks(). I'll send a patch shortly.


Rob