linux-kernel - Re: [PATCH] samples/seccomp: fix 32-bit build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jK1pY-RqB_J5_obMDaWav8cJHjXQkpz0B4cHM=A8Ztq7w@mail.gmail.com>
Date:   Mon, 7 Jan 2019 15:18:27 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Tycho Andersen <tycho@...ho.ws>
Cc:     Ingo Molnar <mingo@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        James Morris <jmorris@...ei.org>,
        Borislav Petkov <bp@...en8.de>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] samples/seccomp: fix 32-bit build

On Mon, Jan 7, 2019 at 3:16 PM Tycho Andersen <tycho@...ho.ws> wrote:
>
> Both the .o and the actual executable need to be built with -m32 in order
> to link correctly.
>
> Signed-off-by: Tycho Andersen <tycho@...ho.ws>
> Reported-by: Ingo Molnar <mingo@...nel.org>
> Fixes: fec7b6690541 ("samples: add an example of seccomp user trap")

Reviewed-by: Kees Cook <keescook@...omium.org>

> ---
> I guess x86 can pick this up directly? Not sure where it should go
> exactly.

Ingo, can you snag this? (It's a more direct path, otherwise I can
take it via seccomp, which will go through my tree then James's
tree...)

-Kees

> ---
>  samples/seccomp/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/samples/seccomp/Makefile b/samples/seccomp/Makefile
> index 4920903c8009..fb43a814d4c0 100644
> --- a/samples/seccomp/Makefile
> +++ b/samples/seccomp/Makefile
> @@ -34,6 +34,7 @@ HOSTCFLAGS_bpf-direct.o += $(MFLAG)
>  HOSTCFLAGS_dropper.o += $(MFLAG)
>  HOSTCFLAGS_bpf-helper.o += $(MFLAG)
>  HOSTCFLAGS_bpf-fancy.o += $(MFLAG)
> +HOSTCFLAGS_user-trap.o += $(MFLAG)
>  HOSTLDLIBS_bpf-direct += $(MFLAG)
>  HOSTLDLIBS_bpf-fancy += $(MFLAG)
>  HOSTLDLIBS_dropper += $(MFLAG)
> --
> 2.19.1
>


-- 
Kees Cook