linux-kernel - Re: + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190107154557.1f4bfeb8bf1aaa45a0d555e3@linux-foundation.org>
Date:   Mon, 7 Jan 2019 15:45:57 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added
 to -mm tree

On Tue, 8 Jan 2019 02:37:20 +0300 Alexey Dobriyan <adobriyan@...il.com> wrote:

> On Mon, Jan 07, 2019 at 02:36:09PM -0800, akpm@...ux-foundation.org wrote:
> > Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes
> > 
> > WARNING: Block comments use * on subsequent lines
> > #56: FILE: fs/proc/proc_net.c:44:
> > +	// /proc/net/* can be changed under us by setns(CLONE_NEWNET)
> > +	pde->proc_dops = &simple_dentry_operations;
> 
> I did it on purpose! Otherwise default vim colouring marks "/*" in red
> because it is comment without "*/"

There's always a way ;)

--- a/fs/proc/proc_net.c~proc-fix-proc-net-after-setns2-checkpatch-fixes-fix
+++ a/fs/proc/proc_net.c
@@ -40,7 +40,7 @@ static struct net *get_proc_net(const st
 
 static void pde_force_lookup(struct proc_dir_entry *pde)
 {
-	/* /proc/net/* can be changed under us by setns(CLONE_NEWNET) */
+	/* /proc/net/ entries can be changed under us by setns(CLONE_NEWNET) */
 	pde->proc_dops = &simple_dentry_operations;
 }
 
_