linux-kernel - Re: [PATCH] v2 staging: rtl8723bs: Clean up dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190107101649.GA2750@kroah.com>
Date:   Mon, 7 Jan 2019 11:16:49 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Aditya Pakki <pakki001@....edu>
Cc:     Arushi Singhal <arushisinghal19971997@...il.com>,
        devel@...verdev.osuosl.org, kjlu@....edu,
        linux-kernel@...r.kernel.org,
        Mamta Shukla <mamtashukla555@...il.com>,
        Colin Ian King <colin.king@...onical.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        Quytelda Kahja <quytelda@...alin.org>,
        Wen Yang <wen.yang99@....com.cn>
Subject: Re: [PATCH] v2 staging: rtl8723bs: Clean up dead code

On Sun, Jan 06, 2019 at 10:20:59AM -0600, Aditya Pakki wrote:
> rtw_wps_start() is part of dead code due to CONFIG_INTEL_WIDI.
> The fix removes the deadcode and replaces the function with NULL
> in rtw_private_handler. Identified as part of copy_from_user bug.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
>  .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 34 +------------------
>  1 file changed, 1 insertion(+), 33 deletions(-)

What changed from v1?  Always put that below the --- line.

Please fix up and send v3.

thanks,

greg k-h