linux-kernel - Re: linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20190107130802.GE3200@kadam>
Date:   Mon, 7 Jan 2019 16:08:03 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     David Binderman <dcb314@...mail.com>
Cc:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re:
 linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]:
 (style) Expression is always false

On Mon, Jan 07, 2019 at 11:40:08AM +0000, David Binderman wrote:
> 
> Hello there,
> 
> linux-5.0-rc1/drivers/staging/rtl8188eu/hal/hal8188e_rate_adaptive.c:412]: (style) Expression is always false because 'else if' condition matches previous condition at line 410.
> 
> Source code is
> 
>         else if (pRaInfo->HighestRate > 0x0b)
>                 pRaInfo->PTModeSS = 2;
>         else if (pRaInfo->HighestRate > 0x0b)
>                 pRaInfo->PTModeSS = 1;
> 

That's true, but that's how to the code was originally when it was
committed 5 years ago so it's hard to tell what the fix should be...

regards,
dan carpenter