linux-kernel - Re: [PATCH] staging: wilc1000: fix cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190107132322.sk3lcvafg65fdd7b@ltop.local>
Date:   Mon, 7 Jan 2019 14:23:23 +0100
From:   Luc Van Oostenryck <luc.vanoostenryck@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Július Milan <julikmilan@...il.com>,
        kbuild test robot <lkp@...el.com>,
        linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, ajay.kathat@...rochip.com,
        linux-wireless@...r.kernel.org, adham.abozaeid@...rochip.com
Subject: Re: [PATCH] staging: wilc1000: fix cast to restricted __le32

On Mon, Jan 07, 2019 at 03:54:37PM +0300, Dan Carpenter wrote:
> I'm sort of surprised that the zero day bot didn't complain about this.
> It probably should.
> 
> The endianness checking is not turned on by default in Sparse.  You have
> to do "make C=1 CF=-D__CHECK_ENDIAN__" to turn it on.

Bitwise (and thus endian) checking is enabled by default in the kernel
since 05de97003 ("linux/types.h: enable endian checks for all sparse builds")
included in v4.10-rc1. Since then they make more than half of sparse
warnings (in a x86-64 allyesconfig).

Best regards,
-- Luc