linux-kernel - Re: Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Jan 2019 15:17:38 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Sinan Kaya <okaya@...nel.org>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH v5 02/11] ata: pata_acpi: Make PCI dependency
 explicit


On 01/07/2019 12:12 PM, Rafael J. Wysocki wrote:
> On Wed, Jan 2, 2019 at 7:11 PM Sinan Kaya <okaya@...nel.org> wrote:
>>
>> After 'commit 5d32a66541c4 ("PCI/ACPI: Allow ACPI to be built without
>> CONFIG_PCI set")' dependencies on CONFIG_PCI that previously were
>> satisfied implicitly through dependencies on CONFIG_ACPI have to be
>> specified directly. PATA_ACPI is a PCI device driver but the PCI
>> dependency has not been explicitly called out.
>>
>> Fixes: 5d32a66541c46 ("PCI/ACPI: Allow ACPI to be built without CONFIG_PCI set")
>> Signed-off-by: Sinan Kaya <okaya@...nel.org>
>> ---
>>  drivers/ata/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
>> index 4ca7a6b4eaae..8218db17ebdb 100644
>> --- a/drivers/ata/Kconfig
>> +++ b/drivers/ata/Kconfig
>> @@ -1091,7 +1091,7 @@ comment "Generic fallback / legacy drivers"
>>
>>  config PATA_ACPI
>>         tristate "ACPI firmware driver for PATA"
>> -       depends on ATA_ACPI && ATA_BMDMA
>> +       depends on ATA_ACPI && ATA_BMDMA && PCI
>>         help
>>           This option enables an ACPI method driver which drives
>>           motherboard PATA controller interfaces through the ACPI
>> --
> 
> Any objections against this one from anyone?

Patch looks correct to me (pata_acpi is indeed a PCI driver):

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

but it is best to wait for Jens' ACK if you want to merge it
through ACPI tree..

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics