linux-kernel - Re: [PATCH] ALSA: usb-audio: fix CM6206 register definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hpnt6izph.wl-tiwai@suse.de>
Date:   Tue, 08 Jan 2019 22:52:58 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Amadeusz Sławiński <amade@...blr.net>
Cc:     <alsa-devel@...a-project.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix CM6206 register definitions

On Tue, 08 Jan 2019 21:03:11 +0100,
Amadeusz Sławiński wrote:
> 
> fix typo after a recent commit causing headphones to have no sound
> 
> Fixes: ad43d528a7ac (ALSA: usb-audio: Define registers for CM6206)
> Signed-off-by: Amadeusz Sławiński <amade@...blr.net>
> ---
>  sound/usb/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 96340f23f86d..ebbadb3a7094 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -768,7 +768,7 @@ static int snd_usb_cm6206_boot_quirk(struct usb_device *dev)
>  		 * REG1: PLL binary search enable, soft mute enable.
>  		 */
>  		CM6206_REG1_PLLBIN_EN |
> -		CM6206_REG1_SOFT_MUTE_EN |
> +		CM6206_REG1_SOFT_MUTE_EN,
>  		/*
>  		 * REG2: enable output drivers,
>  		 * select front channels to the headphone output,

Argh, that's a nasty error, thanks for spotting out.
Applied now.


Takashi