linux-kernel - Re: drivers/staging/media/ipu3/ipu3-css.c:1831: bad compare ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 8 Jan 2019 02:07:20 +0200
From:   "sakari.ailus@...ux.intel.com" <sakari.ailus@...ux.intel.com>
To:     David Binderman <dcb314@...mail.com>
Cc:     "mchehab@...nel.org" <mchehab@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: drivers/staging/media/ipu3/ipu3-css.c:1831: bad compare ?

Hi David,

On Mon, Jan 07, 2019 at 10:30:55PM +0000, David Binderman wrote:
> Hello there,
> 
> drivers/staging/media/ipu3/ipu3-css.c:1831:30: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> 
> Source code is
>         css->pipes[pipe].bindex =
>                 ipu3_css_find_binary(css, pipe, q, r);
>         if (css->pipes[pipe].bindex < 0) {
>                 dev_err(css->dev, "failed to find suitable binary\n");
>                 return -EINVAL;
>         }
> 
> Suggest sanity check return value from function first, then if it is ok,
> assign it to an unsigned variable.

Thanks for reporting this. There have been a few patches to address it so
far, the one going in is here:

<URL:https://patchwork.linuxtv.org/patch/53633/>

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com