linux-kernel - Re: [PATCH] [v3] staging: rtl8723bs: Clean up dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190108095738.GH3200@kadam>
Date:   Tue, 8 Jan 2019 12:57:38 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Aditya Pakki <pakki001@....edu>
Cc:     Arushi Singhal <arushisinghal19971997@...il.com>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Mamta Shukla <mamtashukla555@...il.com>,
        Quytelda Kahja <quytelda@...alin.org>,
        Wen Yang <wen.yang99@....com.cn>
Subject: Re: [PATCH] [v3] staging: rtl8723bs: Clean up dead code

Your subject does work for `git am` but the more normal way to format
it is:

	[PATCH v4] staging: rtl8723bs: Clean up dead code

On Mon, Jan 07, 2019 at 05:20:52PM -0600, Aditya Pakki wrote:
> rtw_wps_start() is part of dead code due to CONFIG_INTEL_WIDI.
> The fix removes the deadcode and replaces the function with NULL
> in rtw_private_handler. Identified as part of copy_from_user bug.
> 
> Changes from v1 & 2:
> The return value of copy_from_user() is not checked appropriately.
> However, maintainers identified the patch fixing the issue is not
> required as function rts_wps_start() is dead code and can be removed.
> 
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---

The "Changed from" comments need to go here under the --- cut off line.
It gets removed from the final kernel git log.

That information is just for maintainers to remember what was discussed
earlier.  It's not needed for the permanent record.

>  .../staging/rtl8723bs/os_dep/ioctl_linux.c    | 34 +------------------
>  1 file changed, 1 insertion(+), 33 deletions(-)

regards,
dan carpenter