linux-kernel - RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7022179F236@SW-EX-MBX02.diasemi.com>
Date:   Tue, 8 Jan 2019 10:21:54 +0000
From:   Steve Twiss <stwiss.opensource@...semi.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
CC:     "mazziesaccount@...il.com" <mazziesaccount@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Support Opensource <Support.Opensource@...semi.com>
Subject: RE: [PATCH] regmap: regmap-irq: silently ignore unsupported type
 settings

Hi Geert,

On 29 December 2018 11:14 Geert Uytterhoeven wrote:

> To: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> Cc: mazziesaccount@...il.com; Mark Brown <broonie@...nel.org>; Greg KH
> <gregkh@...uxfoundation.org>; Rafael J. Wysocki <rafael@...nel.org>; Linux
> Kernel Mailing List <linux-kernel@...r.kernel.org>; Support Opensource
> <Support.Opensource@...semi.com>
> Subject: Re: [PATCH] regmap: regmap-irq: silently ignore unsupported type
> settings
> 
> Hi Matti,
> 
> On Thu, Dec 27, 2018 at 9:44 AM Matti Vaittinen
> <matti.vaittinen@...rohmeurope.com> wrote:
> > Do not return error if irq-type setting is requested for
> > controlloer which does not support this. This is how
> > regmap-irq has previously handled the undupported type
> > settings and existing drivers seem to be upset if failure
> > is now reported.
> >
> > Fixes: 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add level-irq support")
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> 
> Reported-by: Geert Uytterhoeven <geert+renesas@...der.be>
> 
> > ---
> >
> > Geert reported that 1c2928e3e321 breaks da9063-rtc on the Renesas
> > Koelsch board:
> >
> >
> https://lore.kernel.org/lkml/20181227075648.GB2461@localhost.localdomain/T/#
> m194616cc88d7b4c2a78f7ce07907608fdb64a092
> >
> > Geert, do you know if anyone vould to test this?
> 
> Thanks, that seems to fix the issue with da9063-rtc.
> 
> I don't know how to trigger an actual interrupt, though.
> 
> > --- a/drivers/base/regmap/regmap-irq.c
> > +++ b/drivers/base/regmap/regmap-irq.c
> > @@ -258,7 +258,7 @@ static int regmap_irq_set_type(struct irq_data *data,
> unsigned int type)
> >         const struct regmap_irq_type *t = &irq_data->type;
> >
> >         if ((t->types_supported & type) != type)
> > -               return -ENOTSUPP;
> > +               return 0;
> >
> >         reg = t->type_reg_offset / map->reg_stride;
> >
> > --
> > 2.14.3
> 

I've run this patch on the DA9063 set-up I have here. And this fixes the
problem.

Acked-by: Steve Twiss <stwiss.opensource@...semi.com>
Tested-by: Steve Twiss <stwiss.opensource@...semi.com>

Regards,
Steve

My previous report using the unmodified v5.0-rc1 Linux kernel is here:
https://lore.kernel.org/lkml/6ED8E3B22081A4459DAC7699F3695FB7022179F018@SW-EX-MBX02.diasemi.com

This v5.0-rc1 Linux kernel failed to allow IRQs for the MFD cells in the
DA9063. But, altering the v5.0-rc1 kernel with the patch given above (to
return 0 instead of -ENOTSUPP in regmap-irq.c), fixes the problem.

A cut-down console output for this result is given below.

--- 8< ---
[...]
da9063 1-0058: Device detected (chip-ID: 0x61, var-ID: 0x60)
[...]
da9063-onkey da9063-onkey: DMA mask not set
input: da9063-onkey as /devices/soc0/soc/2100000.aips-bus/21a4000.i2c/i2c-1/1-0058/da9063-onkey/input/input2
da9063-rtc da9063-rtc: DMA mask not set
da9063-rtc da9063-rtc: registered as rtc0
[...]
da9063-watchdog da9063-watchdog: DMA mask not set
[...]
da9063-rtc da9063-rtc: setting system clock to 2000-01-01T00:00:00 UTC (946684800)
[...]
--- 8< ---

and the results of setting an RTC alarm and waiting for the interrupt outputs
the following:

--- 8< ---
> cat *.res
[PASS] Set RTC alarms functional test for TEST with DA9063-TEST
[PASS] Setting test type to use BB RTC alarm functional test for TEST with DA9063-TEST
[PASS] Running set alarm tests for RTC { 1 }
[PASS] Running test for test_rtc_prog_set_simple_alarm_seconds()
[PASS] Setting the current date and time from the da9063-rtc as 2000-01-01 00:00:00
[PASS] Setting the alarm date and time from the da9063-rtc as 2000-01-01 00:00:05 (+5 secs into the future)
[PASS] Setting the listener on da9063-rtc then waiting for elapsed timeout of 15 seconds...
[PASS] The alarm was triggered on da9063-rtc within the expected time and the alarm happened at 2000-01-01 00:00:05
[PASS] Running test for test_rtc_prog_set_simple_alarm_seconds()
[PASS] Setting the current date and time from the da9063-rtc as 2000-01-01 00:00:00
[PASS] Setting the alarm date and time from the da9063-rtc as 2000-01-01 00:00:15 (+15 secs into the future)
[PASS] Setting the listener on da9063-rtc then waiting for elapsed timeout of 25 seconds...
[PASS] The alarm was triggered on da9063-rtc within the expected time and the alarm happened at 2000-01-01 00:00:15
[PASS] Finished running DA9063 set alarm tests for RTC { 1 } on TEST
> cat /proc/interrupts | grep da9063
249:          2          0          0          0  gpio-mxc  11 Level     da9063-irq
302:          0          0          0          0  da9063-irq   0 Level     ONKEY
303:          0          0          0          2  da9063-irq   1 Level     ALARM
310:          0          0          0          0  da9063-irq   8 Level     LDO_LIM
> uname -a
Linux test 5.0.0-rc1 #1 SMP Tue Jan 8 09:39:30 GMT 2019 armv7l GNU/Linux
--- 8< ---