linux-kernel - Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f9ab7ba3-573c-6703-1b01-37a9e0a9b769@gmail.com>
Date:   Tue, 8 Jan 2019 20:57:14 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     Zhu Yanjun <yanjun.zhu@...cle.com>, davem@...emloft.net,
        keescook@...omium.org
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency
 use-after-free bugs



On 2019/1/8 20:54, Zhu Yanjun wrote:
>
> 在 2019/1/8 20:45, Jia-Ju Bai 写道:
>> In drivers/net/ethernet/nvidia/forcedeth.c, the functions
>> nv_start_xmit() and nv_start_xmit_optimized() can be concurrently
>> executed with nv_poll_controller().
>>
>> nv_start_xmit
>>    line 2321: prev_tx_ctx->skb = skb;
>>
>> nv_start_xmit_optimized
>>    line 2479: prev_tx_ctx->skb = skb;
>>
>> nv_poll_controller
>>    nv_do_nic_poll
>>      line 4134: spin_lock(&np->lock);
>>      nv_drain_rxtx
>>        nv_drain_tx
>>          nv_release_txskb
>>            line 2004: dev_kfree_skb_any(tx_skb->skb);
>>
>> Thus, two possible concurrency use-after-free bugs may occur.
>>
>> To fix these possible bugs,
>
>
> Does this really occur? Can you reproduce this ?

This bug is not found by the real execution.
It is found by a static tool written by myself, and then I check it by 
manual code review.


Best wishes,
Jia-Ju Bai