linux-kernel - Re: Regression in v5.0-rc1: Panic at boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190108131913.GA6677@lst.de>
Date:   Tue, 8 Jan 2019 14:19:13 +0100
From:   Christoph Hellwig <hch@....de>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Regression in v5.0-rc1: Panic at boot

On Mon, Jan 07, 2019 at 12:41:06PM -0700, Logan Gunthorpe wrote:
> Hey,
> 
> I found a regression in v5.0-rc1 this morning. My system panics on boot.
> I've attached a log of the panic.
> 
> I bisected to find the problematic commit is:
> 
> Fixes: 9d037ad707ed ("block: remove req->timeout_list")
> 
> But it makes no sense to me why this commit would cause a problem like
> this. I've attached a bisect log. I've also tested v5.0-rc1 with this
> commit reverted and that boots fine.
> 
> The traceback seems to indicate the problem is on the bip_get_seed()
> line in t10_pi_complete(). Which suggests that bio_integrity() is
> returning NULL.

Very odd.  Can you try an experiment?  Can you add padding the size
of struct timer_list to struct request to check if that makes the
problem go away?  Then move the padding from the where the field
was to the end and see if that still "helps"?