linux-kernel - RE: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY driver compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VI1PR04MB47996AC5BC20CC53F505880EF28A0@VI1PR04MB4799.eurprd04.prod.outlook.com>
Date:   Tue, 8 Jan 2019 14:07:10 +0000
From:   Camelia Alexandra Groza <camelia.groza@....com>
To:     Scott Wood <oss@...error.net>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: RE: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY driver
 compatible

> -----Original Message-----
> From: Scott Wood <oss@...error.net>
> Sent: Saturday, December 22, 2018 06:07
> To: Camelia Alexandra Groza <camelia.groza@....com>;
> robh+dt@...nel.org; mark.rutland@....com; benh@...nel.crashing.org
> Cc: devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> paulus@...ba.org; linuxppc-dev@...ts.ozlabs.org
> Subject: Re: [PATCH 2/3] powerpc/dts/fsl: t4240rdb: use the Cortina PHY
> driver compatible
> 
> On Wed, 2018-07-18 at 14:46 +0300, Camelia Groza wrote:
> > The Cortina PHY requires the use of the dedicated Cortina PHY driver
> > instead of the generic one.
> >
> > Signed-off-by: Camelia Groza <camelia.groza@....com>
> > ---
> >  arch/powerpc/boot/dts/fsl/t4240rdb.dts | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > index 15eb0a3..a56a705 100644
> > --- a/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > +++ b/arch/powerpc/boot/dts/fsl/t4240rdb.dts
> > @@ -267,22 +267,22 @@
> >
> >  			mdio@...00 {
> >  				xfiphy1: ethernet-phy@10 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x10>;
> >  				};
> >
> >  				xfiphy2: ethernet-phy@11 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x11>;
> >  				};
> >
> >  				xfiphy3: ethernet-phy@13 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x13>;
> >  				};
> >
> >  				xfiphy4: ethernet-phy@12 {
> > -					compatible = "ethernet-phy-
> ieee802.3-
> > c45";
> > +					compatible = "ethernet-phy-
> > id13e5.1002";
> >  					reg = <0x12>;
> >  				};
> >  			};
> 
> I get crashes on boot when using a dtb with this change:

Hi

Sorry for the late replay. I was on vacation. I'm looking into it.

Regards,
Camelia