linux-kernel - Re: [PATCH v2] btrfs: add a check for sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190108155055.GH23615@twin.jikos.cz>
Date:   Tue, 8 Jan 2019 16:50:55 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Chris Mason <clm@...com>,
        Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] btrfs: add a check for sysfs_create_group

On Tue, Dec 25, 2018 at 11:37:44PM -0600, Kangjie Lu wrote:
> In case sysfs_create_group fails, let's check its return value and
> issues an error message.

It's in a function that's not currently used and the sysfs code needs to
be reworked. The return code should be passed to the caller, printing
error message in this case may not be desired but I can't say right now.