linux-kernel - Re: [PATCH 1/3] usb: kconfig: remove dependency FSL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1901081110550.1355-100000@iolanthe.rowland.org>
Date:   Tue, 8 Jan 2019 11:11:37 -0500 (EST)
From:   Alan Stern <stern@...land.harvard.edu>
To:     Ran Wang <ran.wang_1@....com>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Rajesh Bhagat <rajesh.bhagat@....com>
Subject: Re: [PATCH 1/3] usb: kconfig: remove dependency FSL_SOC for ehci
 fsl driver

On Tue, 8 Jan 2019, Ran Wang wrote:

> From: Rajesh Bhagat <rajesh.bhagat@....com>
> 
> CONFIG_USB_EHCI_FSL is not dependent on FSL_SOC, it can be built on
> non-PPC platforms.
> 
> Signed-off-by: Rajesh Bhagat <rajesh.bhagat@....com>
> Signed-off-by: Ran Wang <ran.wang_1@....com>
> ---
>  drivers/usb/host/Kconfig |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 16758b1..53cbc0c 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -179,8 +179,8 @@ config XPS_USB_HCD_XILINX
>  		devices only.
>  
>  config USB_EHCI_FSL
> -	tristate "Support for Freescale PPC on-chip EHCI USB controller"
> -	depends on FSL_SOC
> +	tristate "Support for Freescale on-chip EHCI USB controller"
> +	depends on USB_EHCI_HCD

This line is not needed.  The entire entry lies within an "if 
USB_EHCI_HCD" block.

Alan Stern

>  	select USB_EHCI_ROOT_HUB_TT
>  	---help---
>  	  Variation of ARC USB block used in some Freescale chips.
>