linux-kernel - Re: [PATCH] wireless: marvell: add checks for the return value of sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87va2zqer0.fsf@kamboji.qca.qualcomm.com>
Date:   Tue, 08 Jan 2019 18:46:11 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, "David S. Miller" <davem@...emloft.net>,
        libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wireless: marvell: add checks for the return value of sysfs_create_group

Kangjie Lu <kjlu@....edu> writes:

> sysfs_create_group() could fail, so let's check its return values and
> issue error messages if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@....edu>
> ---
>  drivers/net/wireless/marvell/libertas/mesh.c | 4 ++++

The correct prefix is "libertas: ".

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -797,7 +797,11 @@ static void lbs_persist_config_init(struct net_device *dev)
>  {
>  	int ret;
>  	ret = sysfs_create_group(&(dev->dev.kobj), &boot_opts_group);
> +	if (ret)
> +		pr_err("failed to create boot_opts_group.\n");

Please add an empty line here for readability and resend the patch as
v2.

>  	ret = sysfs_create_group(&(dev->dev.kobj), &mesh_ie_group);
> +	if (ret)
> +		pr_err("failed to create mesh_ie_group.\n");
>  }
>  
>  static void lbs_persist_config_remove(struct net_device *dev)

-- 
Kalle Valo