linux-kernel - Re: [PATCH 04/10] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Jan 2019 09:16:29 -0800
From:   Guenter Roeck <groeck@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>,
        Gwendal Grignou <gwendal@...omium.org>, kernel@...labora.com,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH 04/10] platform/chrome: cros_ec_vbc: remove unused includes

On Tue, Jan 8, 2019 at 8:10 AM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> None of these are required at the moment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> ---
>
>  drivers/platform/chrome/cros_ec_vbc.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_vbc.c b/drivers/platform/chrome/cros_ec_vbc.c
> index af9bfe6f385c..86903bc31b27 100644
> --- a/drivers/platform/chrome/cros_ec_vbc.c
> +++ b/drivers/platform/chrome/cros_ec_vbc.c
> @@ -18,10 +18,8 @@
>   * GNU General Public License for more details.
>   */
>
> -#include <linux/of.h>
>  #include <linux/platform_device.h>
>  #include <linux/mfd/cros_ec.h>
> -#include <linux/mfd/cros_ec_commands.h>

It is customary to not rely on secondary includes. Yet, with this
removal, the code will rely on cros_ec.h including cros_ec_commands.h,
for the definition of EC_VBNV_CONTEXT_OP_READ. Does this really make
sense ?

[ I didn't check the other patches, but I suspect the same applies
there as well ]

Guenter

>  #include <linux/module.h>
>  #include <linux/slab.h>
>
> --
> 2.20.1
>