linux-kernel - Re: [PATCH 4/5] csky: fixup compile error with pte

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wh0H6_Vh3XNQ0EKWa96UFkr7j=v-++2L4kraSLR-RVciQ@mail.gmail.com>
Date:   Tue, 8 Jan 2019 09:33:09 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Guo Ren <guoren@...nel.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>, marc.zyngier@....com,
        Arnd Bergmann <arnd@...db.de>, linux-doc@...r.kernel.org,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Michal Hocko <mhocko@...nel.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Guo Ren <ren_guo@...ky.com>,
        Joel Fernandes <joel@...lfernandes.org>
Subject: Re: [PATCH 4/5] csky: fixup compile error with pte_alloc

On Tue, Jan 8, 2019 at 8:27 AM <guoren@...nel.org> wrote:
>
> +       for (i = 0; i < PAGE_SIZE/sizeof(pte_t); i++)
> +               (pte + i)->pte_low = _PAGE_GLOBAL;

When I first read this, I went "hmm. pte_high is not initialized".

But csky doesn't have a pte_high, and it seems that csky and SH both
decided to call their (single-word) pte member 'pte_low'.

Which is a bit odd, but whatever.

Other than that oddity, it looks fine to me. I assume I'll get a pull
request sooner or later,

              Linus