linux-kernel - Re: [PATCH v4] mm: Create the new vm_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190108182959.GD6310@bombadil.infradead.org>
Date:   Tue, 8 Jan 2019 10:29:59 -0800
From:   Matthew Wilcox <willy@...radead.org>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     akpm@...ux-foundation.org, rppt@...ux.ibm.com, mhocko@...e.com,
        dan.j.williams@...el.com, kirill.shutemov@...ux.intel.com,
        vbabka@...e.cz, riel@...hat.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, william.kucharski@...cle.com
Subject: Re: [PATCH v4] mm: Create the new vm_fault_t type

On Wed, Jan 09, 2019 at 12:00:41AM +0530, Souptick Joarder wrote:
> Page fault handlers are supposed to return VM_FAULT codes,
> but some drivers/file systems mistakenly return error
> numbers. Now that all drivers/file systems have been converted
> to use the vm_fault_t return type, change the type definition
> to no longer be compatible with 'int'. By making it an unsigned
> int, the function prototype becomes incompatible with a function
> which returns int. Sparse will detect any attempts to return a
> value which is not a VM_FAULT code.
> 
> VM_FAULT_SET_HINDEX and VM_FAULT_GET_HINDEX values are changed
> to avoid conflict with other VM_FAULT codes.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
> Reviewed-by: William Kucharski <william.kucharski@...cle.com>
> Reviewed-by: Mike Rapoport <rppt@...ux.ibm.com>

Reviewed-by: Matthew Wilcox <willy@...radead.org>