linux-kernel - Re: [PATCH v3 07/16] Platform: OLPC: Move EC-specific functionality out from x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Jan 2019 12:09:17 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Lubomir Rintel <lkundrak@...sk>
Cc:     kbuild-all@...org, Andy Shevchenko <andy@...radead.org>,
        Darren Hart <dvhart@...radead.org>,
        platform-driver-x86@...r.kernel.org,
        James Cameron <quozl@...top.org>,
        Mark Rutland <mark.rutland@....com>,
        Pavel Machek <pavel@....cz>, Rob Herring <robh+dt@...nel.org>,
        Sebastian Reichel <sre@...nel.org>, x86@...nel.org,
        devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Lubomir Rintel <lkundrak@...sk>
Subject: Re: [PATCH v3 07/16] Platform: OLPC: Move EC-specific functionality
 out from x86

Hi Lubomir,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.0-rc1 next-20190107]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Lubomir-Rintel/Add-support-for-OLPC-XO-1-75-Embedded-Controller/20190108-114514
config: i386-randconfig-x002-201901 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

Note: the linux-review/Lubomir-Rintel/Add-support-for-OLPC-XO-1-75-Embedded-Controller/20190108-114514 HEAD 874facbe5f41ca7d9e5f8921613bd1713cd24b6a builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/power/supply/olpc_battery.c: In function 'olpc_bat_get_status':
>> drivers/power/supply/olpc_battery.c:99:24: error: 'struct olpc_platform_t' has no member named 'ecver'
     if (olpc_platform_info.ecver > 0x44) {
                           ^
   drivers/power/supply/olpc_battery.c: In function 'olpc_battery_probe':
   drivers/power/supply/olpc_battery.c:610:24: error: 'struct olpc_platform_t' has no member named 'ecver'
     if (olpc_platform_info.ecver < 0x44) {
                           ^
   drivers/power/supply/olpc_battery.c:612:43: error: 'struct olpc_platform_t' has no member named 'ecver'
       "battery driver.\n", olpc_platform_info.ecver);
                                              ^

vim +99 drivers/power/supply/olpc_battery.c

1ca5b9d2 drivers/power/olpc_battery.c David Woodhouse 2008-05-04   96  
b2bd8a3b drivers/power/olpc_battery.c Andres Salomon  2008-05-02   97  static int olpc_bat_get_status(union power_supply_propval *val, uint8_t ec_byte)
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04   98  {
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  @99  	if (olpc_platform_info.ecver > 0x44) {
8f7e5798 drivers/power/olpc_battery.c Andres Salomon  2009-06-30  100  		if (ec_byte & (BAT_STAT_CHARGING | BAT_STAT_TRICKLE))
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  101  			val->intval = POWER_SUPPLY_STATUS_CHARGING;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  102  		else if (ec_byte & BAT_STAT_DISCHARGING)
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  103  			val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  104  		else if (ec_byte & BAT_STAT_FULL)
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  105  			val->intval = POWER_SUPPLY_STATUS_FULL;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  106  		else /* er,... */
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  107  			val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  108  	} else {
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  109  		/* Older EC didn't report charge/discharge bits */
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  110  		if (!(ec_byte & BAT_STAT_AC)) /* No AC means discharging */
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  111  			val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  112  		else if (ec_byte & BAT_STAT_FULL)
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  113  			val->intval = POWER_SUPPLY_STATUS_FULL;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  114  		else /* Not _necessarily_ true but EC doesn't tell all yet */
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  115  			val->intval = POWER_SUPPLY_STATUS_CHARGING;
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  116  	}
fb972873 drivers/power/olpc_battery.c David Woodhouse 2007-05-04  117  
b2bd8a3b drivers/power/olpc_battery.c Andres Salomon  2008-05-02  118  	return 0;
b2bd8a3b drivers/power/olpc_battery.c Andres Salomon  2008-05-02  119  }
b2bd8a3b drivers/power/olpc_battery.c Andres Salomon  2008-05-02  120  

:::::: The code at line 99 was first introduced by commit
:::::: fb972873a767220333ffb509de8d9131336e212c [BATTERY] One Laptop Per Child power/battery driver

:::::: TO: David Woodhouse <dwmw2@...radead.org>
:::::: CC: David Woodhouse <dwmw2@...radead.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28383 bytes)