lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 8 Jan 2019 16:48:02 -0800
From:   Roman Kiryanov <rkir@...gle.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] drivers: platform: goldfish: goldfish_sync: add a driver

> You have a number of WARN_ON() calls in here that are not needed, please
> remove.

Thank you for noticing, I will remove them.

> Also, why is this driver needed at all?  Why can't you use the "normal"
> drm sync api interface?  Why write a custom ioctl driver just for this
> one kernel interface?

This driver allows us to talk to host's sync api.

Powered by blists - more mailing lists