linux-kernel - Re: [PATCH V5 1/2] kobject: to repalce printk with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Jan 2019 10:20:17 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Bo YU <tsu.yubo@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Joe Perches <joe@...ches.com>, yuzibode@....com
Subject: Re: [PATCH V5 1/2] kobject: to repalce printk with pr_* style

On Wed, Jan 9, 2019 at 10:17 AM Bo YU <tsu.yubo@...il.com> wrote:
>
> Repalce printk with pr_warn in kobject_synth_uevent and replace
> printk with pr_err in uevent_net_init to make both consistent with
> other code in kobject_uevent.c
>
> Signed-off-by: Bo YU <tsu.yubo@...il.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

>
> ---
> Changes in V2:
> Improve the commit log, doing as the patch did.
> ---
>  lib/kobject_uevent.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
> index 27c6118afd1c..c87a96c4800e 100644
> --- a/lib/kobject_uevent.c
> +++ b/lib/kobject_uevent.c
> @@ -224,7 +224,7 @@ int kobject_synth_uevent(struct kobject *kobj, const char *buf, size_t count)
>  out:
>         if (r) {
>                 devpath = kobject_get_path(kobj, GFP_KERNEL);
> -               printk(KERN_WARNING "synth uevent: %s: %s",
> +               pr_warn("synth uevent: %s: %s",
>                        devpath ?: "unknown device",
>                        msg ?: "failed to send uevent");
>                 kfree(devpath);
> @@ -765,8 +765,7 @@ static int uevent_net_init(struct net *net)
>
>         ue_sk->sk = netlink_kernel_create(net, NETLINK_KOBJECT_UEVENT, &cfg);
>         if (!ue_sk->sk) {
> -               printk(KERN_ERR
> -                      "kobject_uevent: unable to create netlink socket!\n");
> +               pr_err("kobject_uevent: unable to create netlink socket!\n");
>                 kfree(ue_sk);
>                 return -ENODEV;
>         }
> --
> 2.11.0
>