lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Jan 2019 11:58:24 +0100 From: Johan Hovold <johan@...nel.org> To: Nishad Kamdar <nishadkamdar@...il.com> Cc: Johan Hovold <johan@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Alex Elder <elder@...nel.org>, Rui Miguel Silva <rmfrfs@...il.com>, greybus-dev@...ts.linaro.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 2/4] staging: greybus: gpio: Use gpiochip_get_data() in place of gpio_chip_to_gb_gpio_controller() On Sat, Dec 22, 2018 at 08:21:00PM +0530, Nishad Kamdar wrote: > This patch drops gpio_chip_to_gb_gpio_controller(), > and uses gpiochip_get_data() to retrieve the container > of struct gpio_chip. So this will break the driver, since gpiochip_add() sets the data pointer to NULL. These kind of changes are getting too complicated to do without something to test against. We had a module simulator at one point, but not sure what the state of that is now. I appreciate the effort though, and since we already started, let's try to finish, but please drop this patch for now. Johan
Powered by blists - more mailing lists