linux-kernel - Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Jan 2019 10:59:45 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Quentin Perret <quentin.perret@....com>
Cc:     rjw@...ysocki.net, viresh.kumar@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, dietmar.eggemann@....com,
        qais.yousef@....com
Subject: Re: [PATCH] cpufreq: scmi: Fix frequency invariance in slow path

On Wed, Jan 09, 2019 at 10:42:36AM +0000, Quentin Perret wrote:
> The scmi-cpufreq driver calls the arch_set_freq_scale() callback on
> frequency changes to provide scale-invariant load-tracking signals to
> the scheduler. However, in the slow path, it does so while specifying
> the current and max frequencies in different units, hence resulting in a
> broken freq_scale factor.
> 
> Fix this by passing all frequencies in KHz, as stored in the CPUFreq
> frequency table.
> 
> Fixes: 99d6bdf33877 ("cpufreq: add support for CPU DVFS based on SCMI
> message protocol")

Good find.

Acked-by: Sudeep Holla <sudeep.holla@....com>

--
Regards,
Sudeep