linux-kernel - Re: [PATCH v3 2/4] perf record: bind the AIO user space buffers to nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Jan 2019 19:58:14 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/4] perf record: bind the AIO user space buffers to
 nodes

Hi,
On 09.01.2019 18:58, Jiri Olsa wrote:
> On Wed, Jan 09, 2019 at 12:37:17PM +0300, Alexey Budankov wrote:
>>
>> Allocate and bind AIO user space buffers to the memory nodes
>> that mmap kernel buffers are bound to.
<SNIP>
>>
>> Signed-off-by: Alexey Budankov <alexey.budankov@...ux.intel.com>
<SNIP>
>> +static void perf_mmap__aio_bind(struct perf_mmap *map, int index, int cpu, int affinity)
>> +{
>> +	void *data;
>> +	size_t mmap_len;
>> +	unsigned long node_mask;
>> +
>> +	if (affinity != PERF_AFFINITY_SYS && cpu__max_node() > 1) {
>> +		data = map->aio.data[index];
>> +		mmap_len = perf_mmap__mmap_len(map);
>> +		node_mask = 1UL << cpu__get_node(cpu);
>> +		if (mbind(data, mmap_len, MPOL_BIND, &node_mask, 1, 0)) {
>> +			pr_warn("failed to bind [%p-%p] to node %d\n",
>> +				data, data + mmap_len, cpu__get_node(cpu));
>> +		}
> 
> getting compilation fail in here:
> 
>   CC       util/mmap.o
> util/mmap.c: In function ‘perf_mmap__aio_bind’:
> util/mmap.c:193:4: error: implicit declaration of function ‘pr_warn’; did you mean ‘pr_warning’? [-Werror=implicit-function-declaration]
>     pr_warn("failed to bind [%p-%p] to node %d\n",
>     ^~~~~~~
>     pr_warning
> util/mmap.c:193:4: error: nested extern declaration of ‘pr_warn’ [-Werror=nested-externs]
> cc1: all warnings being treated as errors

Yes, it should be pr_warning().
This hunk missed when I was preparing the patches - sorry.
It will be included into v4.

Thanks!
Alexey

> 
> 
> jirka
>