linux-kernel - Re: [PATCH v6 05/12] media: imx-csi: Input connections to CSI should be optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Jan 2019 09:26:39 -0800
From:   Steve Longerbeam <slongerbeam@...il.com>
To:     Philipp Zabel <p.zabel@...gutronix.de>, linux-media@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 05/12] media: imx-csi: Input connections to CSI should
 be optional



On 1/9/19 3:13 AM, Philipp Zabel wrote:
> On Tue, 2019-01-08 at 16:15 -0800, Steve Longerbeam wrote:
>> Some imx platforms do not have fwnode connections to all CSI input
>> ports, and should not be treated as an error. This includes the
>> imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0.
>> Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode
>> endpoint parsing will not treat an unconnected endpoint as an error.
>>
>> Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
>>
>> Signed-off-by: Steve Longerbeam <slongerbeam@...il.com>
>> ---
>>   drivers/staging/media/imx/imx-media-csi.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
>> index e3a4f39dbf73..b276672cae1d 100644
>> --- a/drivers/staging/media/imx/imx-media-csi.c
>> +++ b/drivers/staging/media/imx/imx-media-csi.c
>> @@ -1815,7 +1815,7 @@ static int imx_csi_parse_endpoint(struct device *dev,
>>   				  struct v4l2_fwnode_endpoint *vep,
>>   				  struct v4l2_async_subdev *asd)
>>   {
>> -	return fwnode_device_is_available(asd->match.fwnode) ? 0 : -EINVAL;
>> +	return fwnode_device_is_available(asd->match.fwnode) ? 0 : -ENOTCONN;
>>   }
>>   
>>   static int imx_csi_async_register(struct csi_priv *priv)
> Is this something that should be applied as a fix, separately from this
> series?

Yes. I'll submit it separately and send a v7 of this series without it.

Steve