lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 9 Jan 2019 11:43:07 -0600 From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> To: Patrice CHOTARD <patrice.chotard@...com>, Vinod Koul <vkoul@...nel.org>, Dan Williams <dan.j.williams@...el.com> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] dmaengine: st_fdma: use struct_size() in kzalloc() On 1/7/19 2:50 AM, Patrice CHOTARD wrote: > Hi Gustavo > > On 1/4/19 7:43 PM, Gustavo A. R. Silva wrote: >> One of the more common cases of allocation size calculations is finding the >> size of a structure that has a zero-sized array at the end, along with memory >> for some number of elements for that array. For example: >> [..] >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> >> --- >> drivers/dma/st_fdma.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c >> index 07c20aa2e955..df6b73028ecb 100644 >> --- a/drivers/dma/st_fdma.c >> +++ b/drivers/dma/st_fdma.c >> @@ -243,8 +243,7 @@ static struct st_fdma_desc *st_fdma_alloc_desc(struct st_fdma_chan *fchan, >> struct st_fdma_desc *fdesc; >> int i; >> >> - fdesc = kzalloc(sizeof(*fdesc) + >> - sizeof(struct st_fdma_sw_node) * sg_len, GFP_NOWAIT); >> + fdesc = kzalloc(struct_size(fdesc, node, sg_len), GFP_NOWAIT); >> if (!fdesc) >> return NULL; >> >> > > > Acked-by: Patrice Chotard <patrice.chotard@...com> > Thanks, Patrice. -- Gustavo
Powered by blists - more mailing lists