linux-kernel - Re: [PATCH v2] scsi: sd: Make protection lookup tables static and relocate functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29616f54-5c48-96da-e3b4-c211fd28d82e@acm.org>
Date:   Tue, 8 Jan 2019 18:42:35 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     linuxarm@...wei.com, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2] scsi: sd: Make protection lookup tables static and
 relocate functions

On 1/8/19 7:14 AM, John Garry wrote:
> Currently the protection lookup tables in sd_prot_flag_mask() and
> sd_prot_op() are declared as non-static. As such, they will be rebuilt
> for each respective function call.
> 
> Optimise by making them static.
> 
> This saves ~100B object code for sd.c:
> 
> Before:
>     text	   data	    bss	    dec	    hex	filename
>    25403	   1024	     16	  26443	   674b	drivers/scsi/sd.o
> 
> After:
>    text	   data	    bss	    dec	    hex	filename
>    25299	   1024	     16	  26339	   66e3	drivers/scsi/sd.o
> 
> In addition, since those same functions are declared in sd.h, but each are
> only referenced in sd.c, relocate them to that same c file.
> 
> The inline specifier is dropped also, since gcc should be able to make the
> decision to inline.

Reviewed-by: Bart Van Assche <bvanassche@....org>