lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 9 Jan 2019 19:22:50 +0100
From:   Christian Borntraeger <>
To:     "Michael S. Tsirkin" <>
Cc:     Wei Wang <>,,,,,,,,
Subject: Re: [PATCH v3 1/3] virtio-balloon: tweak config_changed

On 09.01.2019 15:52, Michael S. Tsirkin wrote:
> On Wed, Jan 09, 2019 at 01:07:16PM +0100, Christian Borntraeger wrote:
>> On 09.01.2019 11:35, Wei Wang wrote:
>>> On 01/08/2019 04:46 PM, Christian Borntraeger wrote:
>>>> On 08.01.2019 06:35, Wei Wang wrote:
>>>>> On 01/07/2019 09:49 PM, Christian Borntraeger wrote:
>>>>>> On 07.01.2019 08:01, Wei Wang wrote:
>>>>>>> virtio-ccw has deadlock issues with reading the config space inside the
>>>>>>> interrupt context, so we tweak the virtballoon_changed implementation
>>>>>>> by moving the config read operations into the related workqueue contexts.
>>>>>>> The config_read_bitmap is used as a flag to the workqueue callbacks
>>>>>>> about the related config fields that need to be read.
>>>>>>> The cmd_id_received is also renamed to cmd_id_received_cache, and
>>>>>>> the value should be obtained via virtio_balloon_cmd_id_received.
>>>>>>> Reported-by: Christian Borntraeger <>
>>>>>>> Signed-off-by: Wei Wang <>
>>>>>>> Reviewed-by: Cornelia Huck <>
>>>>>>> Reviewed-by: Halil Pasic <>
>>>>>> Together with
>>>>>>     virtio_pci: use queue idx instead of array idx to set up the vq
>>>>>>     virtio: don't allocate vqs when names[i] = NULL
>>>>>> Tested-by: Christian Borntraeger <>
>>>>> OK. I don't plan to send a new version of the above patches as no changes needed so far.
>>>>> Michael, if the above two patches look good to you, please help add the related tested-by
>>>>> and reviewed-by tags. Thanks.
>>>> Can we also make sure that
>>>> virtio_pci: use queue idx instead of array idx to set up the vq
>>>> virtio: don't allocate vqs when names[i] = NULL
>>>> also land in stable?
>>> You could also send the request to stable after it gets merged to Linus' tree.
>>> The stable review committee will decide whether to take it.
>>> Please see Option 2:
>> Those patches are not upstream yet, Correct?
>> Michael,
>> can you add the stable tag before submitting? If not, can you give me a heads up when doing the
>> pull request so that I can ping the stable folks.
> Can you reply to patches that you feel are needed on stable with just
> Cc:
> in the message body?
> Then it's all automatically handled by ack attaching scripts.

Done. But this only works if those patches are not already part of a tree. I guess they have to go via
your tree, correct?

Powered by blists - more mailing lists