lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 9 Jan 2019 19:30:52 +0100
From:   Linus Walleij <>
To:     Loys Ollivier <>,
        Martin Blumenstingl <>
        <>, Kevin Hilman <>,
        "open list:ARM/Amlogic Meson..." <>,
        Linux ARM <>,
        "" <>,
        Jerome Brunet <>
Subject: Re: [PATCH v2] arm64: dts: meson: Fix mmc cd-gpio polarity

Hi Ollivier!

On Wed, Jan 9, 2019 at 2:56 PM Loys Ollivier <> wrote:

> Commit 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> changed the behavior of "cd-inverted" to follow the device tree bindings
> specification.
> Lines specifying "cd-inverted" are now "acitve high".
> Fix the SD card for meson by setting the cd-gpio as "active low" according
> to the boards specifications.
> Fixes: 89a5e15bcba8 ("gpio/mmc/of: Respect polarity in the device tree")
> Signed-off-by: Loys Ollivier <>
> v2: fix more occurences, also in other meson boards.

This is a good change in itself since it gets rid of some occasions
of the dreaded "cd-inverted" property. I think Martin Blumenstingl
already sent patches like these though (I might be confused).

But we should keep the old device trees working as well.
Can you test if Martins patch:

Also makes your boards work?

Linus Walleij

Powered by blists - more mailing lists