linux-kernel - Re: [GIT PULL] csky fixup for linux-5.0-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wi-4DfZDM2xE2qDnj0acEfgfW5wPWxcps-V5XD8TNAw5w@mail.gmail.com>
Date:   Wed, 9 Jan 2019 10:40:20 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Cc:     pr-tracker-bot@...nel.org, Guo Ren <guoren@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        linux-arch <linux-arch@...r.kernel.org>
Subject: Re: [GIT PULL] csky fixup for linux-5.0-rc1

On Wed, Jan 9, 2019 at 10:30 AM Konstantin Ryabitsev
<konstantin@...uxfoundation.org> wrote:
>
> On Wed, Jan 09, 2019 at 06:05:01PM +0000, pr-tracker-bot@...nel.org wrote:
> > The pull request you sent on Wed,  9 Jan 2019 22:49:57 +0800:
> >
> > > (unable to parse the git remote)
>
> I just committed a fix for this. We weren't expecting URLs without ://
> in them.

Side note: I do wish people would use the proper _public_ access.
Maybe the pr-tracker-bot might even send the person who did a pull
request a (private) notice that there is something odd when that isn't
the case?

Pull requests shouldn't use the ssh address. Yes, it may be where you
_push_ things to, and yes, I can pull from it too (since I have ssh
access to both github and kernel.org), but it's still not the proper
"public-facing" repository address. Not everybody can use those
addresses.

When I remember, I actually end up editing these things up by hand as
I do the pull, because I want the git history to show the publicly
accessible tree. I don't always remember (but I did for the csky
case).

[ In fact, for the ssh://gitolite.kernel.org case, the fixup is
automatic in my git hooks, but for github I have to do it manually ]

               Linus