linux-kernel - Re: [PATCH] Documentation/filesystems: add binderfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110235641.nhuodos74i67jf64@brauner.io>
Date:   Fri, 11 Jan 2019 00:56:42 +0100
From:   Christian Brauner <christian@...uner.io>
To:     Jonathan Corbet <corbet@....net>
Cc:     linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation/filesystems: add binderfs

On Thu, Jan 10, 2019 at 04:47:03PM -0700, Jonathan Corbet wrote:
> On Fri, 11 Jan 2019 00:13:09 +0100
> Christian Brauner <christian@...uner.io> wrote:
> 
> > This documents the Android binderfs filesystem used to dynamically add and
> > remove binder devices that are private to each instance.
> > 
> > Signed-off-by: Christian Brauner <christian.brauner@...ntu.com>
> 
> Seems like a worthwhile addition overall.  I know nothing about binderfs,
> so can't speak to the accuracy, of course.  I do have a couple of
> metacomments, though:
> 
>  - Please consider doing this in RST and tying it into our documentation
>    tree.  It's *almost* RST now, so the effort required will be almost
>    zero.

Oh sure. I simply didn't know. I was just going by the files under
Documentation/filesystems/. Is this a separate git tree? If so, where is
located? Or can I just place it as
Documentation/filesystems/binderfs.rst?

> 
>  - It should probably have an SPDX line at the top.

Yup, can add.

> 
>  - Is it worth putting the example program in the samples/ directory?  Is
>    it something that would ever make any sense to run in its current form?

Hm, I mean I can write a small binary that illustrates mounting and
allocating binder devices in binderfs.

Thanks!
Christian