linux-kernel - Re: [PATCH][re-post] vmbus: fix subchannel removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190110002050.GL166797@sasha-vm>
Date:   Wed, 9 Jan 2019 19:20:50 -0500
From:   Sasha Levin <sashal@...nel.org>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     "'gregkh@...uxfoundation.org'" <gregkh@...uxfoundation.org>,
        'Stephen Hemminger' <stephen@...workplumber.org>,
        Sasha Levin <Alexander.Levin@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        "'devel@...uxdriverproject.org'" <devel@...uxdriverproject.org>,
        "'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        "'marcelo.cerri@...onical.com'" <marcelo.cerri@...onical.com>,
        "'apw@...onical.com'" <apw@...onical.com>,
        "'olaf@...fle.de'" <olaf@...fle.de>,
        vkuznets <vkuznets@...hat.com>,
        "'jasowang@...hat.com'" <jasowang@...hat.com>,
        'Dan B' <dan@...ucturedgrid.net>
Subject: Re: [PATCH][re-post] vmbus: fix subchannel removal

On Wed, Jan 09, 2019 at 08:56:06PM +0000, Dexuan Cui wrote:
>
>The changes to split ring allocation from open/close, broke
>the cleanup of subchannels. This resulted in problems using
>uio on network devices because the subchannel was left behind
>when the network device was unbound.
>
>The cause was in the disconnect logic which used list splice
>to move the subchannel list into a local variable. This won't
>work because the subchannel list is needed later during the
>process of the rescind messages (relid2channel).
>
>The fix is to just leave the subchannel list in place
>which is what the original code did. The list is cleaned
>up later when the host rescind is processed.
>
>Without the fix, we have a lot of "hang" issues in netvsc when we
>try to change the NIC's MTU, set the number of channels, etc.
>
>Fixes: ae6935ed7d42 ("vmbus: split ring buffer allocation from open")
>Cc: stable@...r.kernel.org
>Signed-off-by: Stephen Hemminger <sthemmin@...rosoft.com>
>Signed-off-by: Dexuan Cui <decui@...rosoft.com>

Queued, thank you.

--
Thanks,
Sasha