linux-kernel - Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110065738.GA28817@kroah.com>
Date:   Thu, 10 Jan 2019 07:57:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Peter Chen <hzpeterchen@...il.com>
Cc:     Pawel Laszczak <pawell@...ence.com>, devicetree@...r.kernel.org,
        mark.rutland@....com, linux-usb@...r.kernel.org,
        hdegoede@...hat.com,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        andy.shevchenko@...il.com, robh+dt@...nel.org, rogerq@...com,
        lkml <linux-kernel@...r.kernel.org>, adouglas@...ence.com,
        jbergsagel@...com, nsekhar@...com, nm@...com, sureshp@...ence.com,
        peter.chen@....com, pjez@...ence.com, kurahul@...ence.com
Subject: Re: [PATCH v2 5/5] usb:cdns3 Add Cadence USB3 DRD Driver

On Thu, Jan 10, 2019 at 09:30:41AM +0800, Peter Chen wrote:
> On Mon, Dec 24, 2018 at 12:44 AM Pawel Laszczak <pawell@...ence.com> wrote:
> - debugfs is nice to have feature, I suggest removing it at this
> initial version. Besides, role switch
> through /sys is normal feature, the end user may use it at real
> product, so, it is better at device's
> /sys entry instead of debugfs.
> 
> - I don't know why you add "disable" at debugfs, please comment.

As you imply here, no real-world functionality should ever be in
debugfs as it is an optional system component and kernel code should
work just fine without it being enabled (as more and more systems are
disabling it due to the obvious security problems it has.)

thanks,

greg k-h