linux-kernel - Re: [PATCH] mailbox: tegra-hsp: mark PM functions as __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110081615.GD5213@ulmo>
Date:   Thu, 10 Jan 2019 09:16:15 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     jassisinghbrar@...il.com, jonathanh@...dia.com,
        linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] mailbox: tegra-hsp: mark PM functions as __maybe_unused

On Tue, Jan 08, 2019 at 03:37:13PM +0100, Anders Roxell wrote:
> Without CONFIG_PM_SLEEP, we get annoying warnings about unused
> functions:
> 
> drivers/mailbox/tegra-hsp.c:782:12: warning: ‘tegra_hsp_resume’ defined but not used [-Wunused-function]
>  static int tegra_hsp_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~
> 
> Mark them as __maybe_unused to shut up the warning and silently drop the
> functions without having to add ugly #ifdefs.
> 
> Fixes: 9a63f0f40599 ("mailbox: tegra-hsp: Add suspend/resume support")
> Signed-off-by: Anders Roxell <anders.roxell@...aro.org>
> ---
>  drivers/mailbox/tegra-hsp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)