linux-kernel - Re: [PATCH] kernel: release ptraced tasks before zap_pid_ns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190110083658.GA11083@gmail.com>
Date:   Thu, 10 Jan 2019 00:36:59 -0800
From:   Andrei Vagin <avagin@...il.com>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH] kernel: release ptraced tasks before zap_pid_ns_processes

On Wed, Jan 09, 2019 at 06:08:30PM +0100, Oleg Nesterov wrote:
> On 01/08, Andrei Vagin wrote:
> >
> > No, you don't. The patch looks really nice. Thanks!
> >
> > BTW: We probably need to add the "Fixes:" tag, but I am not sure to which
> > commit, it looks like the issue is here for years.
> 
> I hate you ;)

I know :)

> Ok, OK, this was broken by me in 7c8bd2322c7fd973d089b27de55e29c92c667a06
> "exit: ptrace: shift "reap dead" code from exit_ptrace() to forget_original_parent()"
> 
> > Acked-by: Andrei Vagin <avagin@...il.com>
> 
> Thanks, but if you agree with this patch may I ask you to send v2?
> 
> You found the real problem, my version is only slightly better than yours,
> I don't want to steal the "From" tag. Feel free to add mine signed-of-by.

Thanks Oleg! I will send a second version of this patch.

> 
> Oleg.
>