lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 10 Jan 2019 11:16:13 +0100 From: Gerd Hoffmann <kraxel@...hat.com> To: Noralf Trønnes <noralf@...nnes.org> Cc: dri-devel@...ts.freedesktop.org, David Airlie <airlied@...hat.com>, andr2000@...il.com, David Airlie <airlied@...ux.ie>, open list <linux-kernel@...r.kernel.org>, "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" <virtualization@...ts.linux-foundation.org> Subject: Re: [PATCH v3 14/15] drm/bochs: drop old fbdev emulation code Hi, > > - drm_fb_helper_set_suspend_unlocked(&bochs->fb.helper, 1); > > The generic fbdev emulation doesn't take care of suspend/resume. You > could do this: > drm_fb_helper_set_suspend_unlocked(drm_dev->fb_helper, 1); Additional to drm_mode_config_helper_suspend() I assume? Does the call order matter? > > drm_helper_resume_force_mode(drm_dev); > > The docs for this function has this to say: > * This function is deprecated. New drivers should implement atomic mode- > * setting and use the atomic suspend/resume helpers. > > Maybe you can use drm_mode_config_helper_suspend/resume() instead like > suggested in the drm_fbdev_generic_setup() docs. That should work, yes. The driver is simple enough ;) cheers, Gerd
Powered by blists - more mailing lists