linux-kernel - Re: [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190110113210.6695A60386@smtp.codeaurora.org>
Date:   Thu, 10 Jan 2019 11:32:10 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Zumeng Chen <zumeng.chen@...il.com>
Cc:     <linux-wireless@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <tony@...mide.com>,
        Zumeng Chen <zumeng.chen@...il.com>
Subject: Re: [PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware
 failure

Zumeng Chen <zumeng.chen@...il.com> wrote:

> Release fw_status, raw_fw_status, and tx_res_if when wl12xx_fetch_firmware
> failed instead of meaningless goto out to avoid the following memory leak
> reports(Only the last one listed):
> 
> unreferenced object 0xc28a9a00 (size 512):
>   comm "kworker/0:4", pid 31298, jiffies 2783204 (age 203.290s)
>   hex dump (first 32 bytes):
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>   backtrace:
>     [<6624adab>] kmemleak_alloc+0x40/0x74
>     [<500ddb31>] kmem_cache_alloc_trace+0x1ac/0x270
>     [<db4d731d>] wl12xx_chip_wakeup+0xc4/0x1fc [wlcore]
>     [<76c5db53>] wl1271_op_add_interface+0x4a4/0x8f4 [wlcore]
>     [<cbf30777>] drv_add_interface+0xa4/0x1a0 [mac80211]
>     [<65bac325>] ieee80211_reconfig+0x9c0/0x1644 [mac80211]
>     [<2817c80e>] ieee80211_restart_work+0x90/0xc8 [mac80211]
>     [<7e1d425a>] process_one_work+0x284/0x42c
>     [<55f9432e>] worker_thread+0x2fc/0x48c
>     [<abb582c6>] kthread+0x148/0x160
>     [<63144b13>] ret_from_fork+0x14/0x2c
>     [< (null)>] (null)
>     [<1f6e7715>] 0xffffffff
> 
> Signed-off-by: Zumeng Chen <zumeng.chen@...il.com>

Patch applied to wireless-drivers-next.git, thanks.

ba2ffc96321c wlcore: Fix memory leak in case wl12xx_fetch_firmware failure

-- 
https://patchwork.kernel.org/patch/10736825/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches