linux-kernel - Re: [PATCH] arm: fix a migrating irq bug when hotplug cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52e825c6-6704-c6b9-bbba-a87a0f5ec9cb@arm.com>
Date:   Thu, 10 Jan 2019 12:56:11 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Dietmar Eggemann <dietmar.eggemann@....com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     Russell King - ARM Linux <linux@...linux.org.uk>,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: fix a migrating irq bug when hotplug cpu

On 10/01/2019 10:09, Dietmar Eggemann wrote:
> Arm TC2 fails cpu hotplug stress test.
> 
> This issue was tracked down to a missing copy of the new affinity
> cpumask for the vexpress-spc interrupt into struct
> irq_common_data.affinity when the interrupt is migrated in
> migrate_one_irq().
> 
> Fix it by replacing the arm specific hotplug cpu migration with the
> generic irq code.
> 
> This is the counterpart implementation to commit 217d453d473c ("arm64:
> fix a migrating irq bug when hotplug cpu").
> 
> Tested with cpu hotplug stress test on Arm TC2 (multi_v7_defconfig plus
> CONFIG_ARM_BIG_LITTLE_CPUFREQ=y and CONFIG_ARM_VEXPRESS_SPC_CPUFREQ=y).
> The vexpress-spc interrupt (irq=22) on this board is affine to CPU0.
> Its affinity cpumask now changes correctly e.g. from 0 to 1-4 when
> CPU0 is hotplugged out.
> 
> Suggested-by: Marc Zyngier <marc.zyngier@....com>
> Signed-off-by: Dietmar Eggemann <dietmar.eggemann@....com>

Acked-by: Marc Zyngier <marc.zyngier@....com>

	M.
-- 
Jazz is not dead. It just smells funny...