linux-kernel - Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190110143610.GA142026@google.com>
Date:   Thu, 10 Jan 2019 09:36:10 -0500
From:   Kyle Williams <kdgwill@...omium.org>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:     Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Jack Stocker <jackstocker.93@...il.com>,
        Michael Niewöhner <linux@...ewoehner.de>,
        Nico Sneck <snecknico@...il.com>,
        Tim Anderson <tsa@...lakesoftware.com>,
        Danilo Krummrich <danilokrummrich@...develop.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech
 Flare|Meetup|Brio|Rally

On Mon, Dec 10, 2018 at 03:50:17PM +0200, Mathias Nyman wrote:
> On 08.12.2018 00:18, Kyle Williams wrote:
> > On Tue, Dec 04, 2018 at 04:36:18PM -0500, Alan Stern wrote:
> > > On Tue, 4 Dec 2018, Kyle Williams wrote:
> > > 
> > > > Description: Some USB device / host controller combinations seem to have
> > > > problems with Link Power management. In particular it is described that
> > > > the combination of certain Logitech devices and other powered media
> > > > devices such as the Atrus device causes 'not enough bandwidth for
> > > > new device state'error.
> > > > 
> > > > This patch creates quirk entries for the tested Logitech device
> > > > indicating LPM should remain disabled for the device.
> > > > 
> > > > Signed-off-by: Kyle Williams <kdgwill@...omium.org>
> > > > ---
> > > >   drivers/usb/core/quirks.c | 16 ++++++++++++++++
> > > >   1 file changed, 16 insertions(+)
> > > > 
> > > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> > > > index 0690fcff0ea2..9403edee4797 100644
> > > > --- a/drivers/usb/core/quirks.c
> > > > +++ b/drivers/usb/core/quirks.c
> > > > @@ -246,6 +246,22 @@ static const struct usb_device_id usb_quirk_list[] = {
> > > >          /* Logitech Harmony 700-series */
> > > >          { USB_DEVICE(0x046d, 0xc122), .driver_info = USB_QUIRK_DELAY_INIT },
> > > > 
> > > > +       /* Logitech Flare */
> > > > +       { USB_DEVICE(0x046d, 0x0876), .driver_info = USB_QUIRK_NO_LPM },
> > > 
> > > This entry is out of order with the preceding entry.  And some of the
> > > new entries below are out of order with each other (entries are
> > > supposed to be sorted by Vendor ID, then Product ID).
> > > 
> > > Also, perhaps instead of adding all these new entries, we should set
> > > the NO_LPM quirk flag for all Logitech devices?
> > > 
> > > Alan Stern
> > Setting USB_QUIRK_NO_LPM for all Logitech devices instead of specific
> > ones seem to be a better solution as there are a lot of other devices
> > that have the issue as well
> > 
> > Kyle Williams
> 
> I recently found a cause for the "not enough bandwidth for new device state" error.
> Patch just got applied to v4.20-rc6
> 0472bf0 xhci: Prevent U1/U2 link pm states if exit latency is too long
> 
> Does it work for your Logitech devices?
> 
> -Mathias
> 
Hey Mathias,

The fix specified solved the issues reported for all of the listed
products.

Cheers,
~Kyle