linux-kernel - Re: [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d4ee183e3c2fa964c14a5ac702043c0@codeaurora.org>
Date:   Thu, 10 Jan 2019 20:18:37 +0530
From:   Balakrishna Godavarthi <bgodavar@...eaurora.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Matthias Kaehlcke <mka@...omium.org>, marcel@...tmann.org,
        johan.hedberg@...il.com, linux-kernel@...r.kernel.org,
        linux-bluetooth@...r.kernel.org, hemantg@...eaurora.org,
        linux-arm-msm@...r.kernel.org, Johan Hovold <jhovold@...il.com>
Subject: Re: [PATCH v5 1/5] Bluetooth: hci_qca: use wait_until_sent() for
 power pulses

Hi Johan,

On 2019-01-09 20:08, Johan Hovold wrote:
> On Fri, Dec 21, 2018 at 05:59:47PM -0800, Matthias Kaehlcke wrote:
>> On Thu, Dec 20, 2018 at 08:16:35PM +0530, Balakrishna Godavarthi 
>> wrote:
>> > wcn3990 requires a power pulse to turn ON/OFF along with
>> > regulators. Sometimes we are observing the power pulses are sent
>> > out with some time delay, due to queuing these commands. This is
>> > causing synchronization issues with chip, which intern delay the
>> > chip setup or may end up with communication issues.
>> >
>> > Signed-off-by: Balakrishna Godavarthi <bgodavar@...eaurora.org>
>> > ---
>> >  drivers/bluetooth/hci_qca.c | 38 ++++++++++++++-----------------------
>> >  1 file changed, 14 insertions(+), 24 deletions(-)
>> >
>> > diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
>> > index f036c8f98ea3..5a07c2370289 100644
>> > --- a/drivers/bluetooth/hci_qca.c
>> > +++ b/drivers/bluetooth/hci_qca.c
>> > @@ -1013,11 +1013,9 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)
>> >  		hci_uart_set_baudrate(hu, speed);
>> >  }
>> >
>> > -static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
>> > +static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd)
>> >  {
>> > -	struct hci_uart *hu = hci_get_drvdata(hdev);
>> > -	struct qca_data *qca = hu->priv;
>> > -	struct sk_buff *skb;
>> > +	int ret;
>> >
>> >  	/* These power pulses are single byte command which are sent
>> >  	 * at required baudrate to wcn3990. On wcn3990, we have an external
>> > @@ -1029,19 +1027,16 @@ static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd)
>> >  	 * save power. Disabling hardware flow control is mandatory while
>> >  	 * sending power pulses to SoC.
>> >  	 */
>> > -	bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd);
>> > -
>> > -	skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL);
>> > -	if (!skb)
>> > -		return -ENOMEM;
>> > -
>> > +	bt_dev_dbg(hu->hdev, "sending power pulse %02x to SoC", cmd);
>> >  	hci_uart_set_flow_control(hu, true);
>> > +	ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd));
>> > +	if (ret < 0) {
>> > +		bt_dev_err(hu->hdev, "failed to send power pulse %02x to SoC",
>> > +			   cmd);
>> > +		return ret;
>> > +	}
>> >
>> > -	skb_put_u8(skb, cmd);
>> > -	hci_skb_pkt_type(skb) = HCI_COMMAND_PKT;
>> > -
>> > -	skb_queue_tail(&qca->txq, skb);
>> > -	hci_uart_tx_wakeup(hu);
>> > +	serdev_device_wait_until_sent(hu->serdev, 0);
> 
> Again, do you really want to wait indefinitely here?
> 
[Bala]: these commands are mandatory to turn ON or OFF the chip.
         so blocking to the max time is required.
         these commands are sent during the BT chip ON & OFF.
         in the latest series, i have flushed the uart before sending 
this commands
         so the uart FIFO(as just opened the port before calling this 
function) or the circular
         buffer will be empty and also i am disabling the flow control 
too.
        https://patchwork.kernel.org/patch/10744435/

>> serdev_device_wait_until_sent() might only guarantee that the UART
>> circular buffer is empty (see
>> https://elixir.bootlin.com/linux/v4.19/source/drivers/tty/tty_ioctl.c#L225),
>> not that the data has actually sent (e.g. it might be sitting in
>> the UART FIFO).
> 
> For serial core, uart_wait_until_sent() makes sure also the UART FIFO 
> is
> empty, although it may time out when using flow control (as then the
> FIFO may never empty, and flow control appears to be enabled here).
> 
> Johan


[Bala]: Pls refer the latest patch series 
https://patchwork.kernel.org/patch/10744435/
        where i am flushing the circular buffer before calling the 
qca_send_power_pulse().
        this how the flow

        1. open serial port (gurantess that UART FIFO is empty)
        2. flush the circular buffer
        3. disable the flow control.
        4. send the command byte.
        5. wait for the circular buffer is empty.

        the above is one time process,

-- 
Regards
Balakrishna.