linux-kernel - [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110151020.30468-1-peda@axentia.se>
Date:   Thu, 10 Jan 2019 15:10:28 +0000
From:   Peter Rosin <peda@...ntia.se>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Peter Rosin <peda@...ntia.se>,
        Boris Brezillon <boris.brezillon@...tlin.com>,
        David Airlie <airlied@...ux.ie>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: [PATCH 0/4] drm/atmel-hlcdc: fix plane clipping/rotation issues

Hi!

I found an unfortunate issue while recoding plane handling to use
drm_atomic_helper_check_plane_state(). The driver rotates clockwise,
which is not correct. I simply fixed it (patch 1/4), but maybe that
will cause regressions for unsuspecting users who simply assumed
that the clockwise rotation was correct? I don't know what to do
about that? Adding an option to get the old broken behavior seems
useless, wouldn't it be just as easy to just fix whatever app to
rotate the other way instead of adding an option somewhere?

I have only tested this series on sama5d3, but I did check the docs
for various other chips (sama5d2, sama5d4, sam9n12, sam9g15, sam9g35
and sam9x35) supported by the driver (relevant to patch 4/4).

Cheers,
Peter

Peter Rosin (4):
  drm/atmel-hlcdc: rotate planes counterclockwise
  drm/atmel-hlcdc: do not swap w/h of the crtc when a plane is rotated
  drm/atmel-hlcdc: fix clipping of planes
  drm/atmel-hlcdc: do not immediately disable planes, wait for next
    frame

 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 179 +++++++++---------------
 1 file changed, 67 insertions(+), 112 deletions(-)

-- 
2.11.0