linux-kernel - Re: [PATCH v5 07/15] locking/lockdep: Free lock classes that are no longer in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Jan 2019 16:45:14 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     mingo@...hat.com, tj@...nel.org, longman@...hat.com,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH v5 07/15] locking/lockdep: Free lock classes that are no
 longer in use

On Thu, Jan 10, 2019 at 04:20:35PM +0100, Peter Zijlstra wrote:
> On Mon, Dec 17, 2018 at 01:29:54PM -0800, Bart Van Assche wrote:

> > +	/*
> > +	 * Leak *chain because it is not safe to reinsert it before an RCU
> > +	 * grace period has expired.
> > +	 */
> > +	new_chain = lock_chains + nr_lock_chains++;
> > +	*new_chain = *chain;
> > +	hlist_add_head_rcu(&new_chain->entry, chainhashentry(chain_key));
> > +#endif
> > +}
> 
> Leaking a chain_hlocks[] and lock_chains[] entry is pretty gross, but
> yes that should work.

/me finds patch 10 and goes.. ooh shiny ;-)