linux-kernel - Re: [PATCH v5 11/15] locking/lockdep: Check data structure consistency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190110155509.GJ30894@hirez.programming.kicks-ass.net>
Date:   Thu, 10 Jan 2019 16:55:09 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Bart Van Assche <bvanassche@....org>
Cc:     mingo@...hat.com, tj@...nel.org, longman@...hat.com,
        johannes.berg@...el.com, linux-kernel@...r.kernel.org,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH v5 11/15] locking/lockdep: Check data structure
 consistency

On Mon, Dec 17, 2018 at 01:29:58PM -0800, Bart Van Assche wrote:
> +	/* Check whether all classes occur in a lock list. */
> +	for (i = 0; i < ARRAY_SIZE(lock_classes); i++) {
> +		class = &lock_classes[i];
> +		if (!in_list(&class->lock_entry, &all_lock_classes) &&
> +		    !in_list(&class->lock_entry, &free_lock_classes) &&
> +		    !in_any_zapped_class_list(class)) {
> +			printk(KERN_INFO "class %px/%s is not in any class list\n",
> +			       class, class->name ? : "(?)");
> +			return false;
> +			return false;

I'm thinking just one return statement will suffice ;-)

> +		}
> +	}