linux-kernel - Re: [PATCH v12 6/7] arm64: dts: sdm845: Add interconnect provider DT nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 10 Jan 2019 18:39:22 +0200
From:   Georgi Djakov <georgi.djakov@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andy Gross <andy.gross@...aro.org>,
        Olof Johansson <olof@...om.net>, Arnd Bergmann <arnd@...db.de>,
        linux-pm@...r.kernel.org, "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Rob Herring <robh+dt@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Saravana Kannan <skannan@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Amit Kucheria <amit.kucheria@...aro.org>,
        seansw@....qualcomm.com, daidavid1@...eaurora.org,
        Evan Green <evgreen@...omium.org>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Alexandre Bailon <abailon@...libre.com>,
        maxime.ripard@...tlin.com,
        Thierry Reding <thierry.reding@...il.com>,
        ksitaraman@...dia.com, sanjayc@...dia.com,
        devicetree@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH v12 6/7] arm64: dts: sdm845: Add interconnect provider DT
 nodes

Hi Doug,

On 1/10/19 01:18, Doug Anderson wrote:
> Hi,
> 
> On Sat, Dec 8, 2018 at 9:02 AM Georgi Djakov <georgi.djakov@...aro.org> wrote:
>>
>> From: David Dai <daidavid1@...eaurora.org>
>>
>> Add RSC (Resource State Coordinator) provider
>> dictating network-on-chip interconnect bus performance
>> found on SDM845-based platforms.
>>
>> Signed-off-by: David Dai <daidavid1@...eaurora.org>
>> Signed-off-by: Georgi Djakov <georgi.djakov@...aro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index b72bdb0a31a5..b3cd256a154e 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -1324,6 +1324,11 @@
>>                                 compatible = "qcom,sdm845-rpmh-clk";
>>                                 #clock-cells = <1>;
>>                         };
>> +
>> +                       rsc_hlos: interconnect {
>> +                               compatible = "qcom,sdm845-rsc-hlos";
>> +                               #interconnect-cells = <1>;
>> +                       };
> 
> It would have been convenient if this patch had also added an include above:
> 
> #include <dt-bindings/interconnect/qcom,sdm845.h>
> 
> ...while the include isn't technically needed by this patch, all the
> patches that want to actually _use_ the interconnect will need to add
> the #include and then you get to some fun fights about who has to add
> the include in which patch.  For instance these two patches won't
> compile:
> 
> * https://lkml.kernel.org/r/1545373748-1416-1-git-send-email-jshekhar@codeaurora.org
> * https://lkml.kernel.org/r/20181220173026.3857-4-jcrouse@codeaurora.org
> 
> ...because neither of them happened to add the include.  Maybe they
> were both assuming someone else would do it?
> 
> 
> If nobody else wants to, I'm happy to post a patch to add that include
> myself and it can be applied atop this one.  ...or if this patch needs
> to spin for some other reason maybe you could add it into this patch
> directly?

Ok, i will add it and resend.

Thanks,
Georgi