linux-kernel - Re: [PATCH] xen: Fix x86 sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21d24fe0-f9bd-c312-7773-b43a8ff39ef1@oracle.com>
Date:   Thu, 10 Jan 2019 12:17:20 -0500
From:   Boris Ostrovsky <boris.ostrovsky@...cle.com>
To:     Juergen Gross <jgross@...e.com>, linux-kernel@...r.kernel.org,
        xen-devel@...ts.xenproject.org, x86@...nel.org
Cc:     sstabellini@...nel.org, hpa@...or.com, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, hans@...rrie.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] xen: Fix x86 sched_clock() interface for xen

On 1/10/19 11:14 AM, Juergen Gross wrote:
> On 10/01/2019 16:34, Boris Ostrovsky wrote:
>> On 1/10/19 5:07 AM, Juergen Gross wrote:
>>>  
>>> +void xen_clocksource_suspend(void)
>>> +{
>>> +	xen_clock_value_saved = xen_clocksource_read() - xen_sched_clock_offset;
>>
>> xen_clock_value_saved = xen_sched_clock() maybe? 
> I wanted xen_clocksource_suspend() and xen_clocksource_resume() to
> be symmetrical to each other.

OK.

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@...cle.com>

>
> In case you are feeling strong about that, I'm not. :-) So in case
> you insist on it I can change it. Or you can do so while committing.