linux-kernel - Re: x86/fpu: Don't export __kernel_fpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Jan 2019 19:07:52 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     "Hutter, Tony" <hutter2@...l.gov>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marc Dionne <marc.c.dionne@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: x86/fpu: Don't export __kernel_fpu_{begin,end}()

On 2019-01-10 17:32:58 [+0000], Hutter, Tony wrote:
> > But since when did out-of-tree modules use __kernel_fpu_begin?  It's an
> > x86-only thing, and shouldn't really be used by anyone, right?
> 
> ZFS on Linux uses it for checksums.  Its removal is currently breaking ZFS builds against 5.0:

So btrfs uses crc32c() / kernel's crypto API for that and ZFS can't?
Well the crypto API is GPL only exported so that won't work. crc32c() is
EXPORT_SYMBOL() so it would work.
On the other hand it does not look right to provide a EXPORT_SYMBOL
wrapper around a GPL only interface…

Sebastian